Am 08.09.2023 um 19:16 hat Kevin Wolf geschrieben: > Am 08.09.2023 um 18:11 hat Philippe Mathieu-Daudé geschrieben: > > Hi Kevin, > > > > On 8/9/23 17:01, Kevin Wolf wrote: > > > Am 07.09.2023 um 17:44 hat Stefan Hajnoczi geschrieben: > > > > Applied, thanks. > > > > > > > > Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for > > > > any user-visible changes. > > > > > > Something in this has broken the build for me, it seems to be the > > > linux-user binary that doesn't link any more: > > > > > > /usr/bin/ld: libqemu-x86_64-linux-user.fa.p/target_i386_cpu.c.o: in > > > function `cpu_x86_cpuid': > > > /home/kwolf/source/qemu/build-clang/../target/i386/cpu.c:6180: > > > undefined reference to `kvm_arch_get_supported_cpuid' > > > > My patches. I can not reproduce so far, > > Hm, ok. I can try to bisect it further then.
Right, the commit message is obviously related, so you probably knew this already... :-) commit 3adce820cf9c454b49cabf52b829001ecb98500e Author: Philippe Mathieu-Daudé <phi...@linaro.org> Date: Mon Sep 4 14:43:17 2023 +0200 target/i386: Remove unused KVM stubs All these functions: - kvm_arch_get_supported_cpuid() - kvm_has_smm(() - kvm_hyperv_expand_features() - kvm_set_max_apic_id() are called after checking for kvm_enabled(), which is false when KVM is not built. Since the compiler elides these functions, their stubs are not used and can be removed. Inspired-by: Daniel Henrique Barboza <dbarb...@ventanamicro.com> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Message-ID: <20230904124325.79040-7-phi...@linaro.org> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> target/i386/kvm/kvm-stub.c | 26 -------------------------- 1 file changed, 26 deletions(-) Maybe the calls aren't eliminated because --enable-debug implies -O0? Kevin > > What are your ./configure command options? > > '/home/kwolf/source/qemu/configure' '--cc=clang' > '--target-list=x86_64-linux-user,x86_64-softmmu,arm-softmmu,aarch64-softmmu' > '--enable-debug' '--cxx=clang++' '--disable-blkio' > > Kevin > > > > /usr/bin/ld: libqemu-x86_64-linux-user.fa.p/target_i386_cpu.c.o: in > > > function `x86_cpu_filter_features': > > > /home/kwolf/source/qemu/build-clang/../target/i386/cpu.c:7158: > > > undefined reference to `kvm_arch_get_supported_cpuid' > > > /usr/bin/ld: > > > /home/kwolf/source/qemu/build-clang/../target/i386/cpu.c:7159: undefined > > > reference to `kvm_arch_get_supported_cpuid' > > > /usr/bin/ld: > > > /home/kwolf/source/qemu/build-clang/../target/i386/cpu.c:7160: undefined > > > reference to `kvm_arch_get_supported_cpuid' > > > /usr/bin/ld: > > > /home/kwolf/source/qemu/build-clang/../target/i386/cpu.c:7161: undefined > > > reference to `kvm_arch_get_supported_cpuid' > > > /usr/bin/ld: > > > libqemu-x86_64-linux-user.fa.p/target_i386_cpu.c.o:/home/kwolf/source/qemu/build-clang/../target/i386/cpu.c:7162: > > > more undefined references to `kvm_arch_get_supported_cpuid' follow > > > clang-15: error: linker command failed with exit code 1 (use -v to see > > > invocation) > > > > > > In case it makes a difference, I'm using clang on F37. > > > > > > Kevin > >