Re: [PATCH v2 15/22] net/eth: Clean up local variable shadowing

[Akihiko Odaki]

On 2023/09/05 1:12, Philippe Mathieu-Daudé wrote:

Fix:

   net/eth.c:435:20: error: declaration shadows a local variable 
[-Werror,-Wshadow]
             size_t input_size = iov_size(pkt, pkt_frags);
                    ^
   net/eth.c:413:16: note: previous declaration is here
         size_t input_size = iov_size(pkt, pkt_frags);
                ^

Suggested-by: Akihiko Odaki <akihiko.od...@daynix.com>
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  net/eth.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/net/eth.c b/net/eth.c
index 649e66bb1f..3f680cc033 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -432,8 +432,6 @@ _eth_get_rss_ex_src_addr(const struct iovec *pkt, int 
pkt_frags,
          }

if (opthdr.type == IP6_OPT_HOME) {

-            size_t input_size = iov_size(pkt, pkt_frags);
-
              if (input_size < opt_offset + sizeof(opthdr)) {
                  return false;
              }

Reviewed-by: Akihiko Odaki <akihiko.od...@daynix.com>