On Tue, Sep 19, 2023 at 04:17:43PM +0800, Marc-André Lureau wrote:
> Hi
>
> On Fri, Sep 15, 2023 at 6:16 PM Huang Rui <ray.hu...@amd.com> wrote:
> >
> > Configure context init feature flag for virglrenderer.
> >
> > Originally-by: Antonio Caggiano <antonio.caggi...@collabora.com>
> > Signed-off-by: Huang Rui <ray.hu...@amd.com>
> > ---
> >
> > V4 -> V5:
> > - Inverted patch 5 and 6 because we should configure
> > HAVE_VIRGL_CONTEXT_INIT firstly. (Philippe)
> >
> > meson.build | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/meson.build b/meson.build
> > index 98e68ef0b1..ff20d3c249 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -1068,6 +1068,10 @@ if not get_option('virglrenderer').auto() or
> > have_system or have_vhost_user_gpu
> > prefix: '#include
> > <virglrenderer.h>',
> > dependencies: virgl))
> > endif
> > + config_host_data.set('HAVE_VIRGL_CONTEXT_INIT',
> > +
> > cc.has_function('virgl_renderer_context_create_with_flags',
> > + prefix: '#include
> > <virglrenderer.h>',
> > + dependencies: virgl))
>
> Move it under the "if virgl.found()" block above.
>
> I suggest to name it after what is actually checked:
> HAVE_VIRGL_CONTEXT_CREATE_WITH_FLAGS for ex
>
OK, will update it in V6.
Thanks,
Ray
> > endif
> > blkio = not_found
> > if not get_option('blkio').auto() or have_block
> > --
> > 2.34.1
> >
> >
>
>
> --
> Marc-André Lureau
