On Wed, Aug 23, 2023 at 10:54:24AM +0200, Mads Ynddal wrote: > From: Mads Ynddal <m.ynd...@samsung.com> > > Moved event_mapping and event_id_to_name down one level in the function > call-stack to keep variable instantiation and usage closer (`process` > and `run` has no use of the variables; `read_trace_records` does). > > Instead of passing event_mapping and event_id_to_name to the bottom of > the call-stack, we move their use to `read_trace_records`. This > separates responsibility and ownership of the information. > > `read_record` now just reads the arguments from the file-object by > knowning the total number of bytes. Parsing it to specific arguments is > moved up to `read_trace_records`. > > Special handling of dropped events removed, as they can be handled > by the general code. > > Signed-off-by: Mads Ynddal <m.ynd...@samsung.com> > --- > scripts/simpletrace.py | 115 +++++++++++++++++++---------------------- > 1 file changed, 53 insertions(+), 62 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature
