Hi Eric, >-----Original Message----- >From: Eric Auger <eric.au...@redhat.com> >Sent: Wednesday, September 20, 2023 8:26 PM >Subject: Re: [PATCH v1 06/22] vfio/common: Add a vfio device iterator > >Hi Zhenzhong, > >On 8/30/23 12:37, Zhenzhong Duan wrote: >> With a vfio device iterator added, we can make some migration and reset >> related functions group agnostic. >> E.x: >> vfio_mig_active >> vfio_migratable_device_num >> vfio_devices_all_dirty_tracking >> vfio_devices_all_device_dirty_tracking >> vfio_devices_all_running_and_mig_active >> vfio_devices_dma_logging_stop >> vfio_devices_dma_logging_start >> vfio_devices_query_dirty_bitmap >> vfio_reset_handler >> >> Or else we need to add container specific callback variants for above >> functions just because they iterate devices based on group. >> >> Move the reset handler registration/unregistration to a place that is not >> group specific, saying first vfio address space created instead of the >> first group. >I would move the reset handler registration/unregistration changes in a >separate patch.
Got it. >besides, I don't catch what you mean by >"saying first vfio address space created instead of the first group." Before patch, reset hander is registered in first group creation, after patch, it's registered in first address space creation. The main purpose is to make this code group agnostic. For the device iteration part of this patch, I plan to follow Alex's suggestion to use vfio_device_list for both BEs. Thanks for your time on this patch. BRs. Zhenzhong
