>-----Original Message----- >From: Eric Auger <eric.au...@redhat.com> >Sent: Wednesday, September 20, 2023 9:33 PM >Subject: Re: [PATCH v1 09/22] vfio/container: Introduce >vfio_[attach/detach]_device > >Hi Zhenzhong, > >In the commit title I would replace vfio/container by vfio/pci to match >next patches
Make sense, will do. > >On 8/30/23 12:37, Zhenzhong Duan wrote: >> From: Eric Auger <eric.au...@redhat.com> >> >> We want the VFIO devices to be able to use two different >> IOMMU callbacks, the legacy VFIO one and the new iommufd one. >s/callbacks/backends >> >> Introduce vfio_[attach/detach]_device which aim at hiding the >> underlying IOMMU backend (IOCTLs, datatypes, ...). > ...... >> diff --git a/hw/vfio/trace-events b/hw/vfio/trace-events >> index ee7509e68e..8016d9f0d2 100644 >> --- a/hw/vfio/trace-events >> +++ b/hw/vfio/trace-events >> @@ -37,7 +37,7 @@ vfio_pci_hot_reset_dep_devices(int domain, int bus, int >slot, int function, int >> vfio_pci_hot_reset_result(const char *name, const char *result) "%s hot >reset: %s" >> vfio_populate_device_config(const char *name, unsigned long size, unsigned >long offset, unsigned long flags) "Device %s config:\n size: 0x%lx, offset: >0x%lx, >flags: 0x%lx" >> vfio_populate_device_get_irq_info_failure(const char *errstr) >"VFIO_DEVICE_GET_IRQ_INFO failure: %s" >> -vfio_realize(const char *name, int group_id) " (%s) group %d" >> +vfio_realize(const char *name) " (%s)" >I am not sure this trace point is useful anymore, without the id. Some >tracepoints shall be BE specific to keep their usefulness and should be >called from container.c/iommufd.c instead of in the generic function. Previously I use this trace event just to hint vfio realize starting. I agree with you that being BE specific could show more useful information. I'll fix it in v2. Thanks Zhenzhong
