On 22/12/22 09:54, Gao, Lu wrote:
Hello,
Just want to check whether we can have it merged? Any other comments?
Oops sorry, I see I had this patch tagged for a merge request
but I lost track of it (likely when switching emails).
Patch queued!
Thanks a lot!
B.R.
-----Original Message-----
From: Philippe Mathieu-Daudé [mailto:philippe.mathieu.da...@gmail.com] On
Behalf Of Philippe Mathieu-Daudé
Sent: Tuesday, May 31, 2022 6:09 PM
To: Gao, Lu; qemu-devel@nongnu.org
Cc: Wen, Jianxian; Bin Meng; open list:SD (Secure Card); Alexander Bulekov;
Prasad J Pandit
Subject: Re: [PATCH] hw/sd/sdhci: Block Size Register bits [14:12] is lost
On 21/3/22 06:56, Lu Gao wrote:
Block Size Register bits [14:12] is SDMA Buffer Boundary, it is missed
in register write, but it is needed in SDMA transfer. e.g. it will be
used in sdhci_sdma_transfer_multi_blocks to calculate boundary_ variables.
Missing this field will cause wrong operation for different SDMA Buffer
Boundary settings.
Fixes: d7dfca0807 ("hw/sdhci: introduce standard SD host controller")
Fixes: dfba99f17f ("hw/sdhci: Fix DMA Transfer Block Size field")
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Signed-off-by: Lu Gao <lu....@verisilicon.com>
Signed-off-by: Jianxian Wen <jianxian....@verisilicon.com>
---
hw/sd/sdhci.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
