----- Original Message ----- > From: "Anthony Liguori" <anth...@codemonkey.ws> > To: "Federico Simoncelli" <fsimo...@redhat.com> > Cc: "Paolo Bonzini" <pbonz...@redhat.com>, kw...@redhat.com, > arm...@redhat.com, "Jeff Cody" <jc...@redhat.com>, > mtosa...@redhat.com, qemu-devel@nongnu.org, "Luiz Capitulino" > <lcapitul...@redhat.com> > Sent: Monday, February 27, 2012 5:42:31 PM > Subject: Re: [Qemu-devel] drive transactions (was Re: [PATCH 2/2 v2] Add the > blockdev-reopen and blockdev-migrate > commands) > > On 02/27/2012 10:33 AM, Federico Simoncelli wrote: > > I'm all for the modularity of the commands (I suggested it since > > the beginning), > > but all this infrastructure goes way beyond what I'd need for oVirt > > now. > > > > When I submitted my patches we knew that my work wasn't the > > definitive solution > > (eg: the future implementation of -blockdev). So I'd suggest to try > > and settle > > with something that is good enough and that is not preventing a > > future improvement. > > > > What about having a (temporary) flag in drive-mirror to accept also > > a new-image-file > > until we will have the optimal solution? > > Unless there are extenuating circumstances (like the absence of core > infrastructure in QEMU), then we should not add commands that we know > are not > the right command.
So are you in favor or against my suggestion? It looks like this is exactly the case where the core infrastructure (transactions) is missing. -- Federico
