BALATON Zoltan <bala...@eik.bme.hu> writes:
> On Mon, 27 Feb 2023, Philippe Mathieu-Daudé wrote:
>> On 3/2/23 15:55, Philippe Mathieu-Daudé wrote:
>>> Since now PCI and SysBus properties are identical, unify them.
>>> Suggested-by: BALATON Zoltan <bala...@eik.bme.hu>
>>> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
>>> ---
>>> hw/display/sm501.c | 11 +++--------
>>> 1 file changed, 3 insertions(+), 8 deletions(-)
>>> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
>>> index efebd93f1e..98375138b2 100644
>>> --- a/hw/display/sm501.c
>>> +++ b/hw/display/sm501.c
>>> @@ -1975,7 +1975,7 @@ static void sm501_realize_sysbus(DeviceState *dev,
>>> Error **errp)
>>> /* TODO : chain irq to IRL */
>>> }
>>> -static Property sm501_sysbus_properties[] = {
>>> +static Property sm501_common_properties[] = {
>>> DEFINE_PROP_UINT32("vram-size", SM501SysBusState, vram_size, 0),
>>> DEFINE_PROP_END_OF_LIST(),
>>> };
>>
>>
>>> @@ -2062,11 +2062,6 @@ static void sm501_realize_pci(PCIDevice *dev, Error
>>> **errp)
>>> &s->state.mmio_region);
>>> }
>>> -static Property sm501_pci_properties[] = {
>>> - DEFINE_PROP_UINT32("vram-size", SM501PCIState, vram_size, 64 * MiB),
>
> Oops, indeed the defaults are different so maybe just drop this patch for now.
Okay, I'm ignoring this patch.
