+David Markus Armbruster <arm...@redhat.com> writes:
> Philippe Mathieu-Daudé <phi...@linaro.org> writes: > >> DEFINE_PROP_DMAADDR() is only used once. Since it doesn't >> add much value, simply remove it, along with the header >> defining it. >> >> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> > > DEFINE_PROP_DMAADDR() lets you wrap a property around a dma_addr_t > member without assuming anything about dma_addr_t. > > If we use its (trivial) expansion instead, we assume dma_addr_t is > uint64_t. > > Whether that's worth avoiding I can't say. Depends on how much the > abstraction leaks in other ways. Thoughts?
