On 18/09/2023 22:41, Markus Armbruster wrote: > Functions that use an Error **errp parameter to return errors should > not also report them to the user, because reporting is the caller's > job. When the caller does, the error is reported twice. When it > doesn't (because it recovered from the error), there is no error to > report, i.e. the report is bogus. > > qemu_rdma_exchange_send() violates this principle: it calls > error_report() via callback qemu_rdma_reg_whole_ram_blocks(). I > elected not to investigate how callers handle the error, i.e. precise > impact is not known. > > Clean this up by converting the callback to Error. > > Signed-off-by: Markus Armbruster<arm...@redhat.com>
Reviewed-by: Li Zhijian <lizhij...@fujitsu.com>
