Peter Xu <pet...@redhat.com> wrote: > On Mon, Sep 25, 2023 at 03:55:08PM +0200, Markus Armbruster wrote: >> Peter Xu <pet...@redhat.com> writes: >> >> > It's not obvious to many that RDMA migration is in Odd Fixes stage for a >> > long time. Add an explicit sub entry for it (besides migration, which >> > already covers the rdma files) to be clear on that, meanwhile add Zhijian >> > as Reviewer, so Zhijian can see the patches and review when he still has >> > the bandwidth. >> > >> > Cc: Daniel P. Berrangé <berra...@redhat.com> >> > Cc: Juan Quintela <quint...@redhat.com> >> > Cc: Markus Armbruster <arm...@redhat.com> >> > Cc: Zhijian Li (Fujitsu) <lizhij...@fujitsu.com> >> > Cc: Fabiano Rosas <faro...@suse.de> >> > Signed-off-by: Peter Xu <pet...@redhat.com> >> > --- >> > MAINTAINERS | 5 +++++ >> > 1 file changed, 5 insertions(+) >> > >> > diff --git a/MAINTAINERS b/MAINTAINERS >> > index 355b1960ce..f6b21da753 100644 >> > --- a/MAINTAINERS >> > +++ b/MAINTAINERS >> > @@ -3217,6 +3217,11 @@ F: qapi/migration.json >> > F: tests/migration/ >> > F: util/userfaultfd.c >> > >> > +RDMA Migration >> > +R: Li Zhijian <lizhij...@fujitsu.com> >> > +S: Odd Fixes >> > +F: migration/rdma* >> > + >> > Migration dirty limit and dirty page rate >> > M: Hyman Huang <yong.hu...@smartx.com> >> > S: Maintained >> >> Hmm... >> >> $ scripts/get_maintainer.pl --status -f migration/rdma.cLi Zhijian >> <lizhij...@fujitsu.com> (reviewer:RDMA Migration) >> Juan Quintela <quint...@redhat.com> (maintainer:Migration) >> Peter Xu <pet...@redhat.com> (reviewer:Migration) >> Leonardo Bras <leob...@redhat.com> (reviewer:Migration) >> qemu-devel@nongnu.org (open list:All patches CC here) >> Odd Fixes >> Maintained >> >> Contradictory status. Do we care? > > Not a problem to me, but if you or anyone thinks that's better, please feel > free to post another patch to replace this one with Zhijian's ACK attached.
Sending Markus version with Zhijian ACK. >> >> To avoid, try something like the appended patch. With that one: >> >> $ scripts/get_maintainer.pl --status -f migration/rdma.c >> Juan Quintela <quint...@redhat.com> (odd fixer:RDMA Migration) >> Li Zhijian <lizhij...@fujitsu.com> (reviewer:RDMA Migration) >> Peter Xu <pet...@redhat.com> (reviewer:RDMA Migration) >> Leonardo Bras <leob...@redhat.com> (reviewer:RDMA Migration) >> qemu-devel@nongnu.org (open list:All patches CC here) >> Odd Fixes >> >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 355b1960ce..3e80857eab 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -3216,6 +3216,15 @@ F: docs/devel/migration.rst >> F: qapi/migration.json >> F: tests/migration/ >> F: util/userfaultfd.c >> +X: migration/rdma* >> + >> +RDMA Migration >> +M: Juan Quintela <quint...@redhat.com> >> +R: Li Zhijian <lizhij...@fujitsu.com> >> +R: Peter Xu <pet...@redhat.com> >> +R: Leonardo Bras <leob...@redhat.com> >> +S: Odd Fixes >> +F: migration/rdma* > > It's slightly a pity we need to copy the lines, and I think this may not be > the only place where we have >1 entries pointing to the same file. > >> >> Migration dirty limit and dirty page rate >> M: Hyman Huang <yong.hu...@smartx.com> >> > > Thanks,