On 04.10.23 03:45, Stefan Hajnoczi wrote:
vhost_kernel_reset_device() invokes RESET_OWNER, which disassociates the
owner process from the device. The device is left non-operational since
SET_OWNER is only called once during startup in vhost_dev_init().
vhost_kernel_reset_device() is never called so this latent bug never
appears. Get rid of vhost_kernel_reset_device() for now. If someone
needs it in the future they'll need to implement it correctly.
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
---
hw/virtio/vhost-backend.c | 6 ------
1 file changed, 6 deletions(-)
The obvious way would be to immediately call SET_OWNER again, but I
assume that just like in vhost-user, it is probably pretty much left
undefined what exactly should happen in the back-end on RESET_OWNER, and
so I agree that in general, starting to call this function now when we
didn’t before is more of a liability then anything.
Reviewed-by: Hanna Czenczek <hre...@redhat.com>
