On 28/09/2023 21:19, Markus Armbruster wrote: > qemu_rdma_exchange_get_response() compares int parameter @expecting > with uint32_t head->type. Actual arguments are non-negative > enumeration constants, RDMAControlHeader uint32_t member type, or > qemu_rdma_exchange_recv() int parameter expecting. Actual arguments > for the latter are non-negative enumeration constants. Change both > parameters to uint32_t. > > In qio_channel_rdma_readv(), loop control variable @i is ssize_t, and > counts from 0 up to @niov, which is size_t. Change @i to size_t. > > While there, make qio_channel_rdma_readv() and > qio_channel_rdma_writev() more consistent: change the former's @done > to ssize_t, and delete the latter's useless initialization of @len. > > Signed-off-by: Markus Armbruster<arm...@redhat.com> > Reviewed-by: Fabiano Rosas<faro...@suse.de>
Reviewed-by: Li Zhijian <lizhij...@fujitsu.com>