> From: David Hildenbrand <da...@redhat.com>
> Sent: Monday, October 9, 2023 1:22 PM
> To: Salil Mehta <salil.me...@huawei.com>; qemu-devel@nongnu.org; qemu-
> a...@nongnu.org
> Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron
> <jonathan.came...@huawei.com>; lpieral...@kernel.org;
> peter.mayd...@linaro.org; richard.hender...@linaro.org;
> imamm...@redhat.com; andrew.jo...@linux.dev; phi...@linaro.org;
> eric.au...@redhat.com; oliver.up...@linux.dev; pbonz...@redhat.com;
> m...@redhat.com; w...@kernel.org; gs...@redhat.com; raf...@kernel.org;
> alex.ben...@linaro.org; li...@armlinux.org.uk;
> dar...@os.amperecomputing.com; il...@os.amperecomputing.com;
> vis...@os.amperecomputing.com; karl.heub...@oracle.com;
> miguel.l...@oracle.com; salil.me...@opnsrc.net; zhukeqian
> <zhukeqi...@huawei.com>; wangxiongfeng (C) <wangxiongfe...@huawei.com>;
> wangyanan (Y) <wangyana...@huawei.com>; jiakern...@gmail.com;
> maob...@loongson.cn; lixiang...@loongson.cn; Linuxarm <linux...@huawei.com>
> Subject: Re: [PATCH V3 02/10] hw/acpi: Move CPU ctrl-dev MMIO region len
> macro to common header file
>
> On 09.10.23 13:28, Salil Mehta wrote:
> > CPU ctrl-dev MMIO region length could be used in ACPI GED and various
> other
> > architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more
> > appropriate common header file.
> >
> > Signed-off-by: Salil Mehta <salil.me...@huawei.com>
> > Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
> > Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com>
> > Reviewed-by: Gavin Shan <gs...@redhat.com>
> > ---
> > hw/acpi/cpu.c | 2 +-
> > include/hw/acpi/cpu_hotplug.h | 2 ++
> > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c
> > index 19c154d78f..45defdc0e2 100644
> > --- a/hw/acpi/cpu.c
> > +++ b/hw/acpi/cpu.c
> > @@ -1,12 +1,12 @@
> > #include "qemu/osdep.h"
> > #include "migration/vmstate.h"
> > #include "hw/acpi/cpu.h"
> > +#include "hw/acpi/cpu_hotplug.h"
> > #include "qapi/error.h"
> > #include "qapi/qapi-events-acpi.h"
> > #include "trace.h"
> > #include "sysemu/numa.h"
> >
> > -#define ACPI_CPU_HOTPLUG_REG_LEN 12
> > #define ACPI_CPU_SELECTOR_OFFSET_WR 0
> > #define ACPI_CPU_FLAGS_OFFSET_RW 4
> > #define ACPI_CPU_CMD_OFFSET_WR 5
> > diff --git a/include/hw/acpi/cpu_hotplug.h
> b/include/hw/acpi/cpu_hotplug.h
> > index 3b932abbbb..48b291e45e 100644
> > --- a/include/hw/acpi/cpu_hotplug.h
> > +++ b/include/hw/acpi/cpu_hotplug.h
> > @@ -19,6 +19,8 @@
> > #include "hw/hotplug.h"
> > #include "hw/acpi/cpu.h"
> >
> > +#define ACPI_CPU_HOTPLUG_REG_LEN 12
> > +
> > typedef struct AcpiCpuHotplug {
> > Object *device;
> > MemoryRegion io;
>
> Reviewed-by: David Hildenbrand <da...@redhat.com>
Thanks
Salil.
