Missing review: #1 #2 #3 v2: - Addressed Ani's review comments (patches #2, #3) - Added R-b tags
Clean up global variables shadowing in hw/ in order to be able to use -Wshadow with Clang. Philippe Mathieu-Daudé (6): hw/core/cpu: Clean up global variable shadowing hw/loader: Clean up global variable shadowing in rom_add_file() hw/display/vga: Clean up global variable shadowing hw/acpi/pcihp: Clean up global variable shadowing in acpi_pcihp_init() hw/pci: Clean up global variable shadowing of address_space_io variable hw/s390x: Clean up global variable shadowing in quiesce_powerdown_req() hw/display/vga_int.h | 4 ++-- include/hw/acpi/pcihp.h | 2 +- include/hw/core/cpu.h | 8 ++++---- include/hw/loader.h | 11 ++++++----- include/hw/pci/pci.h | 9 +++------ cpu-common.c | 6 +++--- hw/acpi/pcihp.c | 5 ++--- hw/core/loader.c | 10 +++++----- hw/display/vga.c | 12 ++++++------ hw/pci/pci.c | 25 +++++++++---------------- hw/s390x/sclpquiesce.c | 8 ++++---- target/s390x/cpu_models.c | 2 +- 12 files changed, 46 insertions(+), 56 deletions(-) -- 2.41.0