On 11/10/2023 20.46, Fabiano Rosas wrote:
We've found the source of flakiness in this test, so re-enable it.

Reviewed-by: Juan Quintela <quint...@redhat.com>
Signed-off-by: Fabiano Rosas <faro...@suse.de>
---
  tests/qtest/migration-test.c | 10 ++--------
  1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 2dc6ac2f87..049463ee5e 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -3068,14 +3068,8 @@ int main(int argc, char **argv)
      }
      qtest_add_func("/migration/multifd/tcp/plain/none",
                     test_multifd_tcp_none);
-    /*
-     * This test is flaky and sometimes fails in CI and otherwise:
-     * don't run unless user opts in via environment variable.
-     */
-    if (getenv("QEMU_TEST_FLAKY_TESTS")) {
-        qtest_add_func("/migration/multifd/tcp/plain/cancel",
-                       test_multifd_tcp_cancel);
-    }
+    qtest_add_func("/migration/multifd/tcp/plain/cancel",
+                   test_multifd_tcp_cancel);
      qtest_add_func("/migration/multifd/tcp/plain/zlib",
                     test_multifd_tcp_zlib);
  #ifdef CONFIG_ZSTD

Acked-by: Thomas Huth <th...@redhat.com>


Reply via email to