Hi Jonathan,
> From: Jonathan Cameron <jonathan.came...@huawei.com>
> Sent: Thursday, October 12, 2023 3:36 PM
> To: Salil Mehta <salil.me...@huawei.com>
> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean-
> phili...@linaro.org; lpieral...@kernel.org; peter.mayd...@linaro.org;
> richard.hender...@linaro.org; imamm...@redhat.com; andrew.jo...@linux.dev;
> da...@redhat.com; phi...@linaro.org; eric.au...@redhat.com;
> oliver.up...@linux.dev; pbonz...@redhat.com; m...@redhat.com;
> w...@kernel.org; gs...@redhat.com; raf...@kernel.org;
> alex.ben...@linaro.org; li...@armlinux.org.uk;
> dar...@os.amperecomputing.com; il...@os.amperecomputing.com;
> vis...@os.amperecomputing.com; karl.heub...@oracle.com;
> miguel.l...@oracle.com; salil.me...@opnsrc.net; zhukeqian
> <zhukeqi...@huawei.com>; wangxiongfeng (C) <wangxiongfe...@huawei.com>;
> wangyanan (Y) <wangyana...@huawei.com>; jiakern...@gmail.com;
> maob...@loongson.cn; lixiang...@loongson.cn; Linuxarm <linux...@huawei.com>
> Subject: Re: [PATCH V5 1/9] accel/kvm: Extract common KVM vCPU
> {creation,parking} code
>
> On Wed, 11 Oct 2023 20:43:47 +0100
> Salil Mehta <salil.me...@huawei.com> wrote:
>
> > KVM vCPU creation is done once during the initialization of the VM when
> Qemu
> > thread is spawned. This is common to all the architectures.
> >
> > Hot-unplug of vCPU results in destruction of the vCPU object in QOM but
> the
> > corresponding KVM vCPU object in the Host KVM is not destroyed and its
> > representative KVM vCPU object/context in Qemu is parked.
> >
> > Refactor common logic so that some APIs could be reused by vCPU Hotplug
> > code.
>
> If you are respinning I'd also call out that you added some trace points.
Ok. Will do.
Thanks
> > Signed-off-by: Salil Mehta <salil.me...@huawei.com>
> > Reviewed-by: Gavin Shan <gs...@redhat.com>
> > Tested-by: Vishnu Pajjuri <vis...@os.amperecomputing.com>
> Otherwise LGTM as it's a straight forward refactor.
>
> Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com>
>
