On 12/10/2023 04:35, Juan Quintela wrote:
> The only user of ram_control_save_page() and save_page() hook was
> rdma. Just move the function to rdma.c, rename it to
> rdma_control_save_page().
>
> Reviewed-by: Peter Xu <pet...@redhat.com>
> Signed-off-by: Juan Quintela <quint...@redhat.com>
[...]
>
> +int rdma_control_save_page(QEMUFile *f, ram_addr_t block_offset,
> + ram_addr_t offset, size_t size)
> +{
> + if (!migrate_rdma()) {
> + return RAM_SAVE_CONTROL_NOT_SUPP;
> + }
> +
> + int ret = qemu_rdma_save_page(f, block_offset, offset, size);
> +
> + if (ret != RAM_SAVE_CONTROL_DELAYED &&
> + ret != RAM_SAVE_CONTROL_NOT_SUPP) {
> + if (ret < 0) {
> + qemu_file_set_error(f, ret);
> + }
> + }
> + return ret;
> +}
> +
> +
Redundant new line？
Reviewed-by: Li Zhijian <lizhij...@fujitsu.com>
> static void rdma_accept_incoming_migration(void *opaque);
>
> static void rdma_cm_poll_handler(void *opaque)
> @@ -3989,7 +4008,6 @@ static const QEMUFileHooks rdma_read_hooks = {
> };
>
> static const QEMUFileHooks rdma_write_hooks = {
> - .save_page = qemu_rdma_save_page,
> };
>
>
