On Thu, Jul 26, 2012 at 3:14 AM, Marco Hugentobler <[email protected]> wrote: > Hi Etienne > > >> What I have done for the format options is make is a standalone >> widget, and it is included in the file save as dialog and gdal >> options, as well as in the gdaltools dialogs (overviews only for >> illustration). Would we want that for every component, or perhaps have >> a single widget with optional sections that can be displayed according >> to context?. > > > Embedding is certainly the cleaner solution than disabling sections.
This might lead to much more complex code - with a UI file and class for each component. Any ideas on how to streamline this? Perhaps keep all the c++ code in one file, and have a base class for all components that has initializing, getting result and signals/slots? Etienne > > Marco > > > > Am 25.07.2012 14:00, schrieb Etienne Tourigny: > >> +1 for me also >> >> It would be nice to discuss how the file save as dialog should be >> organised, and how much of it could be reusable. >> >> I think that a first candidate for using the file save as dialog >> components would be gdaltools - see the modified merge tool. >> >> Some elements might not be necessary in all use cases. For example, >> we could have an overviews section (line in the gdaltools overviews >> tool), but it would not be necessary in other dialogs. >> >> In the case of the full-blown "save as" dialog, all components could >> be present, but with a ui to hide/display them (with something like a >> toolbox, tabs, collapsible comboboxes). >> >> What I have done for the format options is make is a standalone >> widget, and it is included in the file save as dialog and gdal >> options, as well as in the gdaltools dialogs (overviews only for >> illustration). Would we want that for every component, or perhaps have >> a single widget with optional sections that can be displayed according >> to context?. >> >> cheers >> Etienne >> >> On Tue, Jul 24, 2012 at 3:44 PM, Radim Blazek <[email protected]> >> wrote: >>> >>> On Tue, Jul 24, 2012 at 7:15 PM, Radim Blazek <[email protected]> >>> wrote: >>>> >>>> On Tue, Jul 24, 2012 at 4:53 PM, Marco Hugentobler >>>> <[email protected]> wrote: >>>>> >>>>> Hi all >>>>> >>>>> I think it would be a good move to merge the raster-pipes-2 branch back >>>>> to >>>>> trunk. Ok, I know more instabilities, things to polish, etc. But in >>>>> trunk, >>>>> it receives more attention and people are more motivated to work on it. >>>>> >>>>> Any objections? >>>> >>>> Tests should pass OK before merge, I think. Then +1. >>> >>> Fixed. Now +1. >>> >>> Radim >>> >>>> Do you want to merge everything as a single commit or all commits from >>>> raster-pipes-2? I would prefer to squash my initial work on pipes >>>> (87607187-2fdd82f4) into a single commit. >>>> >>>> Radim >>>> >>>> >>>>> Regards, >>>>> Marco >>>>> >>>>> Am 20.07.2012 22:15, schrieb Tim Sutton: >>>>> >>>>>> Hi >>>>>> >>>>>> On Fri, Jul 20, 2012 at 10:13 PM, Etienne Tourigny >>>>>> <[email protected]> wrote: >>>>>>> >>>>>>> Ok this is a more general question then - which format(s) should >>>>>>> raster export support? >>>>>>> >>>>>> It should support any GDAL raster driver that supports write and that >>>>>> is useable with the active dataset. >>>>>> >>>>>> I was referring to tif only in terms of the default profiles I >>>>>> mentioned. >>>>>> >>>>>> Regards >>>>>> >>>>>> Tim >>>>>> >>>>>>> Etienne >>>>>>> >>>>>>> On Fri, Jul 20, 2012 at 5:11 PM, Tim Sutton <[email protected]> >>>>>>> wrote: >>>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> On Fri, Jul 20, 2012 at 10:07 PM, Etienne Tourigny >>>>>>>> <[email protected]> wrote: >>>>>>>> >>>>>>>>>> One thing that would be really nice is to have >>>>>>>>>> some default profiles: >>>>>>>>>> >>>>>>>>>> - options for maximum read performance regardless of disk space >>>>>>>>>> - options for minumum file size regardless of performance >>>>>>>>>> - options for 'middle of the road' between the above two >>>>>>>>> >>>>>>>>> would you have these options for all file types? it could get a >>>>>>>>> little >>>>>>>>> complex, but worth the effort. For now I am implementing 1 default >>>>>>>>> for >>>>>>>>> each driver, which can be defined by the user. >>>>>>>>> >>>>>>>> I was thinking just for tiff as I think it is the most generically >>>>>>>> used. >>>>>>>> >>>>>>>> Regards >>>>>>>> >>>>>>>> Tim >>>>>>>> >>>>>>>>> Etienne >>>>>>>>> >>>>>>>>>> Regards >>>>>>>>>> >>>>>>>>>> Tim >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>>> I have granted you write access, please work directly in >>>>>>>>>>>> raster-pipes-2. >>>>>>>>>>> >>>>>>>>>>> thanks >>>>>>>>>>> Etienne >>>>>>>>>>> >>>>>>>>>>>> Radim >>>>>>>>>>>> >>>>>>>>>>>>> Etienne >>>>>>>>>>>>> >>>>>>>>>>>>> On Thu, Jul 19, 2012 at 7:21 PM, Tim Sutton >>>>>>>>>>>>> <[email protected]> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> Hi >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Fri, Jul 20, 2012 at 12:19 AM, Etienne Tourigny >>>>>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Thu, Jul 19, 2012 at 4:09 PM, Marco Hugentobler >>>>>>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi Etienne >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks for the feedback, very much appreciated. I've fixed >>>>>>>>>>>>>>>> these >>>>>>>>>>>>>>>> issues in >>>>>>>>>>>>>>>> raster-pipes-2 branch now. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> There are still a few things missing in raster saving: >>>>>>>>>>>>>>>> - write colortable to output dataset >>>>>>>>>>>>>>>> - format specific options (e.g. compression) >>>>>>>>>>>>>>>> - dynamic populating of the format combo box (currently >>>>>>>>>>>>>>>> hardcoded to >>>>>>>>>>>>>>>> geotiff) >>>>>>>>>>>>>>>> - progress indication for tile based saving and possibility >>>>>>>>>>>>>>>> to >>>>>>>>>>>>>>>> cancel >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> It just occurred to me that it would be a great thing to >>>>>>>>>>>>>>> implement >>>>>>>>>>>>>>> this as a widget+class in QgisGui, so that it could be used >>>>>>>>>>>>>>> elsewhere >>>>>>>>>>>>>>> (e.g. gdaltools, sextante). >>>>>>>>>>>>>>> >>>>>>>>>>>>>> You mean as a reusable widget like the crs selector? Yes that >>>>>>>>>>>>>> would be great! >>>>>>>>>>>>>> >>>>>>>>>>>>>> Regards >>>>>>>>>>>>>> >>>>>>>>>>>>>> Tim >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Any way I can help? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Regards, >>>>>>>>>>>>>>>> Marco >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On 18.07.2012 21:12, Etienne Tourigny wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Noticed a few issues with the save dialog >>>>>>>>>>>>>>>>> 1) "format" drop-down is empty >>>>>>>>>>>>>>>>> 2) cannot select a new file >>>>>>>>>>>>>>>>> 3) segfault when saving to an existing file >>>>>>>>>>>>>>>>> 4) It would be nice to have that action in the legend >>>>>>>>>>>>>>>>> contextual menu, >>>>>>>>>>>>>>>>> like for vector layers. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> regards, >>>>>>>>>>>>>>>>> Etienne >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Wed, Jul 18, 2012 at 3:59 PM, Etienne Tourigny >>>>>>>>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> That's great news! >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Concerning raster saving - will there be a mechanism for >>>>>>>>>>>>>>>>>> compressing >>>>>>>>>>>>>>>>>> files? >>>>>>>>>>>>>>>>>> It would be great if default compression schemes could be >>>>>>>>>>>>>>>>>> chosen for >>>>>>>>>>>>>>>>>> different file types, and an option at save time - sort of >>>>>>>>>>>>>>>>>> like image >>>>>>>>>>>>>>>>>> editors. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> I had trouble building it with external spatialite, could >>>>>>>>>>>>>>>>>> only >>>>>>>>>>>>>>>>>> get it >>>>>>>>>>>>>>>>>> to compile with cmake -DWITH_INTERNAL_SPATIALITE=TRUE - >>>>>>>>>>>>>>>>>> does >>>>>>>>>>>>>>>>>> this >>>>>>>>>>>>>>>>>> require a special version of spatialite? >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> regards, >>>>>>>>>>>>>>>>>> Etienne >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On Wed, Jul 18, 2012 at 12:13 PM, Marco Hugentobler >>>>>>>>>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Hi devs >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> I'd like to announce the branch 'raster-pipes-2' in >>>>>>>>>>>>>>>>>>> Radims >>>>>>>>>>>>>>>>>>> repository >>>>>>>>>>>>>>>>>>> https://github.com/blazek/Quantum-GIS for testing. >>>>>>>>>>>>>>>>>>> Radim did a great job in refactoring the process of >>>>>>>>>>>>>>>>>>> reading / >>>>>>>>>>>>>>>>>>> resampling >>>>>>>>>>>>>>>>>>> / >>>>>>>>>>>>>>>>>>> reprojecting / displaying / modifying raster layers. >>>>>>>>>>>>>>>>>>> Every >>>>>>>>>>>>>>>>>>> step is now a >>>>>>>>>>>>>>>>>>> subclass of QgsRasterInterface, with the advantage that >>>>>>>>>>>>>>>>>>> several steps >>>>>>>>>>>>>>>>>>> can be >>>>>>>>>>>>>>>>>>> chained in a QgsRasterPipe. Like that, the raster >>>>>>>>>>>>>>>>>>> functionality is >>>>>>>>>>>>>>>>>>> nicely >>>>>>>>>>>>>>>>>>> separated into different classes and it is easy to >>>>>>>>>>>>>>>>>>> add/remove >>>>>>>>>>>>>>>>>>> elements >>>>>>>>>>>>>>>>>>> in >>>>>>>>>>>>>>>>>>> the pipe. The iteration over the raster parts is >>>>>>>>>>>>>>>>>>> controlled >>>>>>>>>>>>>>>>>>> by >>>>>>>>>>>>>>>>>>> QgsRasterIterator (because for high-resolution prints or >>>>>>>>>>>>>>>>>>> analysis on >>>>>>>>>>>>>>>>>>> large >>>>>>>>>>>>>>>>>>> datasets, it is impossible to keep everything in memory >>>>>>>>>>>>>>>>>>> at >>>>>>>>>>>>>>>>>>> once). >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Please report any issue you find in the branch to the >>>>>>>>>>>>>>>>>>> developer mailing >>>>>>>>>>>>>>>>>>> list. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Besides the changes in code architecture, there is also a >>>>>>>>>>>>>>>>>>> new >>>>>>>>>>>>>>>>>>> feature in >>>>>>>>>>>>>>>>>>> the >>>>>>>>>>>>>>>>>>> raster-pipes-2 branch. It is now possible to write >>>>>>>>>>>>>>>>>>> through >>>>>>>>>>>>>>>>>>> QgsRasterDataProvider (currently only supported by the >>>>>>>>>>>>>>>>>>> gdal >>>>>>>>>>>>>>>>>>> provider). >>>>>>>>>>>>>>>>>>> There >>>>>>>>>>>>>>>>>>> is a 'save as...' function also for rasters now (though >>>>>>>>>>>>>>>>>>> it is >>>>>>>>>>>>>>>>>>> not 100% >>>>>>>>>>>>>>>>>>> complete at the moment). There is the option to save a >>>>>>>>>>>>>>>>>>> raster >>>>>>>>>>>>>>>>>>> in one >>>>>>>>>>>>>>>>>>> file or >>>>>>>>>>>>>>>>>>> in tiles (the tiles are then saved in one directory and >>>>>>>>>>>>>>>>>>> vrt / >>>>>>>>>>>>>>>>>>> pyramides >>>>>>>>>>>>>>>>>>> are >>>>>>>>>>>>>>>>>>> automatically created. Very usefull for saving the >>>>>>>>>>>>>>>>>>> contents >>>>>>>>>>>>>>>>>>> of a WMS >>>>>>>>>>>>>>>>>>> layer). >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Regards, >>>>>>>>>>>>>>>>>>> Marco >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>> Dr. Marco Hugentobler >>>>>>>>>>>>>>>>>>> Sourcepole - Linux & Open Source Solutions >>>>>>>>>>>>>>>>>>> Weberstrasse 5, CH-8004 Zürich, Switzerland >>>>>>>>>>>>>>>>>>> [email protected] http://www.sourcepole.ch >>>>>>>>>>>>>>>>>>> Technical Advisor QGIS Project Steering Committee >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>>>>>>>>> Qgis-developer mailing list >>>>>>>>>>>>>>>>>>> [email protected] >>>>>>>>>>>>>>>>>>> http://lists.osgeo.org/mailman/listinfo/qgis-developer >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>> Dr. Marco Hugentobler >>>>>>>>>>>>>>>> Sourcepole - Linux & Open Source Solutions >>>>>>>>>>>>>>>> Churerstrasse 22, CH-8808 Pfäffikon SZ, Switzerland >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> [email protected] http://www.sourcepole.ch >>>>>>>>>>>>>>>> Technical Advisor QGIS Project Steering Committee >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>>>>> Qgis-developer mailing list >>>>>>>>>>>>>>> [email protected] >>>>>>>>>>>>>>> http://lists.osgeo.org/mailman/listinfo/qgis-developer >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Tim Sutton - QGIS Project Steering Committee Member (Release >>>>>>>>>>>>>> Manager) >>>>>>>>>>>>>> ============================================== >>>>>>>>>>>>>> Please do not email me off-list with technical >>>>>>>>>>>>>> support questions. Using the lists will gain >>>>>>>>>>>>>> more exposure for your issues and the knowledge >>>>>>>>>>>>>> surrounding your issue will be shared with all. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Visit http://linfiniti.com to find out about: >>>>>>>>>>>>>> * QGIS programming and support services >>>>>>>>>>>>>> * Mapserver and PostGIS based hosting plans >>>>>>>>>>>>>> * FOSS Consulting Services >>>>>>>>>>>>>> Skype: timlinux >>>>>>>>>>>>>> Irc: timlinux on #qgis at freenode.net >>>>>>>>>>>>>> ============================================== >>>>>>>>>>>>> >>>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>>> Qgis-developer mailing list >>>>>>>>>>>>> [email protected] >>>>>>>>>>>>> http://lists.osgeo.org/mailman/listinfo/qgis-developer >>>>>>>>>>> >>>>>>>>>>> _______________________________________________ >>>>>>>>>>> Qgis-developer mailing list >>>>>>>>>>> [email protected] >>>>>>>>>>> http://lists.osgeo.org/mailman/listinfo/qgis-developer >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Tim Sutton - QGIS Project Steering Committee Member (Release >>>>>>>>>> Manager) >>>>>>>>>> ============================================== >>>>>>>>>> Please do not email me off-list with technical >>>>>>>>>> support questions. Using the lists will gain >>>>>>>>>> more exposure for your issues and the knowledge >>>>>>>>>> surrounding your issue will be shared with all. >>>>>>>>>> >>>>>>>>>> Visit http://linfiniti.com to find out about: >>>>>>>>>> * QGIS programming and support services >>>>>>>>>> * Mapserver and PostGIS based hosting plans >>>>>>>>>> * FOSS Consulting Services >>>>>>>>>> Skype: timlinux >>>>>>>>>> Irc: timlinux on #qgis at freenode.net >>>>>>>>>> ============================================== >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Tim Sutton - QGIS Project Steering Committee Member (Release >>>>>>>> Manager) >>>>>>>> ============================================== >>>>>>>> Please do not email me off-list with technical >>>>>>>> support questions. Using the lists will gain >>>>>>>> more exposure for your issues and the knowledge >>>>>>>> surrounding your issue will be shared with all. >>>>>>>> >>>>>>>> Visit http://linfiniti.com to find out about: >>>>>>>> * QGIS programming and support services >>>>>>>> * Mapserver and PostGIS based hosting plans >>>>>>>> * FOSS Consulting Services >>>>>>>> Skype: timlinux >>>>>>>> Irc: timlinux on #qgis at freenode.net >>>>>>>> ============================================== >>>>>> >>>>>> >>>>>> >>>>> >>>>> -- >>>>> Dr. Marco Hugentobler >>>>> Sourcepole - Linux & Open Source Solutions >>>>> Weberstrasse 5, CH-8004 Zürich, Switzerland >>>>> [email protected] http://www.sourcepole.ch >>>>> Technical Advisor QGIS Project Steering Committee >>>>> >>>>> _______________________________________________ >>>>> Qgis-developer mailing list >>>>> [email protected] >>>>> http://lists.osgeo.org/mailman/listinfo/qgis-developer >>> >>> _______________________________________________ >>> Qgis-developer mailing list >>> [email protected] >>> http://lists.osgeo.org/mailman/listinfo/qgis-developer > > > > -- > Dr. Marco Hugentobler > Sourcepole - Linux & Open Source Solutions > Weberstrasse 5, CH-8004 Zürich, Switzerland > [email protected] http://www.sourcepole.ch > Technical Advisor QGIS Project Steering Committee > _______________________________________________ Qgis-developer mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/qgis-developer
