Having nothing to do with the code I'd vote for removing QgsColorButton and letting the V2 do all the work (sounds newer to me - probably the original is only used by old dialogues) Inserting it in the Widget itself sounds also resonable to me .. probably search for some special cases where it would not be needed - but I think it does not hurt to have it implemented in the Widget .. Thanks for doing all this work!
kind regards Werner On Mon, Jan 7, 2013 at 4:13 PM, Matthias Kuhn <[email protected]> wrote: > Hi all, > > I've just had a look at QgsColorButton. > > There are two implementations available (QgsColorButton and > QgsColorButtonV2). Would it be okay to remove one of them before the 2.0 > release? If yes, which one should be removed? > > I also noticed, that in several places, the onClick event is handled to > open a QColorDialog and assign the selected color to the button. > Wouldn't it be nice, if this behavior would be part of the widget > implementation itself? > > Regards, > Matthias > ______________________________**_________________ > Qgis-developer mailing list > [email protected] > http://lists.osgeo.org/**mailman/listinfo/qgis-**developer<http://lists.osgeo.org/mailman/listinfo/qgis-developer> >
_______________________________________________ Qgis-developer mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/qgis-developer
