Hi Larry, OK. Thanks for clarification.
I understand the decision to have a one theme. That's is fine. However, I like to do my own compile version with nkids in Mac OS X later on. Is it possible. I like to see first are the set of icons needs to be done. Thanks. Noli On 4/16/13, Larry Shaffer <lar...@dakotacarto.com> wrote: > Hi Noli, > > On Mon, Apr 15, 2013 at 7:00 PM, Noli Sicad <nsi...@gmail.com> wrote: > >> Hi Larry, >> >> What is the summary of this posting? >> > > Some time ago, devs voted to move to the 'gis' theme as the default, i.e. > not just the one selected by default but also the only theme supported by > the project. Even after this update, you may notice the icons are still > hodge-podge with inconsistent ones needing work. Due to lack of developers > to maintain multiple project-supported themes, it is best to have only one, > so that a concerted effort can be made to keep it complete and cohesive. > > Does mean that we can use themes in QGIS 2.0? >> > > No theme support code was removed, only the gis theme condensed upon the > current default (because many default icons are still used) and old project > themes removed. However, there has been talk of removing all theme support, > but I can't speak to the state of that decision. > > I like to revive my nkids theme for QGIS 2.0 as option for Mac OS X >> QGIS, is this possible? >> > > I'm not entirely sure, but to use a different theme than the default, you > will need to add it to the appropriate source directories, edit the .qrc > files and compile the source again. For example, nkids has been in the > source themes directory for awhile, but not choose-able in the gui because > it is not been made part of compiled-in resource system. > > I did add some code to push any old saved theme choice over to the new > default, so if you did add a revamped nkids theme, maybe considering giving > it a new name as well. > > > If I am misunderstanding the current state of decisions regarding the move > forward for icon themes, somebody please correct me (see also [0]). > > Regards, > > Larry > > [0] http://hub.qgis.org/issues/7551 > > Thanks. >> >> Noli >> >> >> >> On 4/16/13, Larry Shaffer <lar...@dakotacarto.com> wrote: >> > Hi, >> > >> > So, I've pushed a large update to master that condenses down the >> > default >> > icon theme by overriding it with the gis theme (the theme voted to be >> > the >> > replacement). I apologize if the change is abrupt, but it needed done >> with >> > enough time to edit/fix things before 2.0 release. >> > >> > I did this in the following manner: >> > >> > 1) Copied the gis theme over the default theme. Any files of same name >> were >> > replaced, missing files added. The was done for plugins that also >> > managed >> > icon sets per theme (grass, georeferencer and ftools). >> > >> > The state of previous icon theme sets and directory structure are >> preserved >> > as a download here [0] (saves switching local or browsing online git >> > repo >> > to find replaced/removed ones). These can be added back to source >> > directory, for reference, or not. >> > >> > 2) Updated all appropriate .qrc and .ui files that referenced old theme >> > paths. >> > >> > 3) Switched some icons to improve consistency (mostly to + and - icons >> for >> > table widget row editing) >> > >> > 4) Proofed every dialog I could think of, though I'm sure I missed >> > something. This was from both running from build directory and from >> > installed app on Mac. >> > >> > 5) Added some code to ensure any old saved theme choice now goes to >> > default. No theme support code was removed. >> > >> > 6) Updated CMakeList.txt files to ensure SVGs are also copied on >> > install. >> > >> > >> > Where to go from here: >> > >> > * Please, let me know if I made a mistake somewhere. >> > >> > * We now have a single set of icons on which to work and update. Icons >> > should be updated, especially those that don't match current theme. >> > >> > * Moving to SVG can be aided by leaving the getThemeIcon/Pixmap calls >> > and >> > referencing the file by base name, without extension, e.g. >> > QgsApplication::getThemePixmap( "pie-chart" ). When using this >> > technique, >> > as soon as a .png is replaced with a .svg in a .qrc resource file, it >> > is >> > auto-found, without having to edit anymore code. Let me know if this >> > approach should be used. >> > >> > [0] >> http://drive.dakotacarto.com/qgis/QGIS-images_pre-gis-theme-switch.zip >> > >> > Regards, >> > >> > Larry >> > >> > _______________________________________________ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer