>I prefer to remove the label only if the user gives an empty text. > Can I do it ?
No objection from me. Currently, I'm not using the text replacement capabilities.
Marco On 28.05.2013 11:34, René-Luc D'Hont wrote:
Hi Marco I guess yes. 'adjustSizeToText()' works for text, not html. Html support for composer label was added recently to the composer label class. Please adapt the relevant lines to work with htmllabels too.I'll adapt it >Question for Marco, Why removed label, if the request doesn't define a value ? Why not used the default value ? The idea was that the web client has the possibility to remove an advertised text label completely if it is not used. E.g. if a composition defines a text item with id 'author', the web client can simply ignore it if it does not want to have author's name printed. Note that the labels without ids are not removed as they are considered to be fix, so not subject to client text replacement (original meaning of label id was that this text item is subject to text replacement by web client. Later, the id has been generalized as an id for every item type). Another possibility would be to remove the item only if the client gives an empty text and use the default text otherwise. What do you think? I prefer to remove the label only if the user gives an empty text. Can I do it ? Regards, René-Luc On 27.05.2013 22 <tel:27.05.2013%2022>:23, rldhont wrote: Hi Marco and other devs, In src/mapserver/qgsconfigparser.cpp:530 we can read : //replace label text foreach ( QgsComposerLabel *currentLabel, composerLabels ) { QString title = parameterMap.value( currentLabel->id().toUpper() ); if ( title.isEmpty() ) { //remove exported labels not referenced in the request if ( !currentLabel->id().isEmpty() ) { c->removeItem( currentLabel ); delete currentLabel; } continue; } currentLabel->setText( title ); currentLabel->adjustSizeToText(); } This code is used to draw composer label with value defined by the QGIS WMS Server Request GetPrint. The bug defined in the issues #7894 http://hub.qgis.org/issues/7894 is probably du to the method adjustSizeToText() Someone can confim it ? Question for Marco, Why removed label, if the request doesn't define a value ? Why not used the default value ? Regards, René-Luc D'Hont 3Liz _______________________________________________ Qgis-developer mailing list [email protected] <mailto:[email protected]> http://lists.osgeo.org/mailman/listinfo/qgis-developer-- Dr. Marco HugentoblerSourcepole - Linux & Open Source Solutions Weberstrasse 5, CH-8004 Zürich, Switzerland [email protected] <mailto:[email protected]> http://www.sourcepole.ch Technical Advisor QGIS Project Steering Committee _______________________________________________ Qgis-developer mailing list [email protected] <mailto:[email protected]> http://lists.osgeo.org/mailman/listinfo/qgis-developer
-- Dr. Marco Hugentobler Sourcepole - Linux & Open Source Solutions Weberstrasse 5, CH-8004 Zürich, Switzerland [email protected] http://www.sourcepole.ch Technical Advisor QGIS Project Steering Committee
_______________________________________________ Qgis-developer mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/qgis-developer
