Hi Sandro
Click-click mode in the context of the node tool means that you click on
a node to move and you release it with a second click (as opposed to
dragging nodes).
The implementation of the c.-c. mode had issues and therefore was
changed back to drag mode.
Just reverting this commit is not a good fix, as it also changes the
behaviour of the node tool. Instead you should debug why things go wrong
during snapping.
Regards,
Marco
On 06/28/16 08:47, Sandro Santilli wrote:
Hi Marco,
I'm not sure you get hub.qgis.org notifications so I'm writing you
directly. It is about a regression which was introduced by a commit
of yours:
commit 9c2d70186f054b71f1b792d13133f3856c855bf3
Author: Marco Hugentobler <[email protected]>
Date: Wed Sep 16 05:19:26 2015 +0200
Node tool without click-click mode
src/app/nodetool/qgsmaptoolnodetool.cpp | 500 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------
src/app/nodetool/qgsmaptoolnodetool.h | 49 ++++++----
src/app/nodetool/qgsnodeeditor.cpp | 23 ++---
src/app/nodetool/qgsnodeeditor.h | 1 -
src/app/nodetool/qgsselectedfeature.cpp | 53 ++---------
src/app/nodetool/qgsselectedfeature.h | 3 -
6 files changed, 391 insertions(+), 238 deletions(-)
The above commit introduced a bug which is easily reproducible with
this project file: http://hub.qgis.org/attachments/9958/bug_qgis_13952.zip
And these instructions: http://hub.qgis.org/issues/13952#note-11
I verified reverting the commit fixes the issue, and that
qgsnodeeditor.{cpp,h} changes have no effect, so the offending
patch is either in qgsmaptoolnodetool.{cpp,h} or
qgsselectedfeature.{cpp,h}
Could you help figuring out what the changes you added really did ?
The commit message isn't clear ("click-click mode"?).
Thanks in advance.
--strk;
() Free GIS & Flash consultant/developer
/\ https://strk.kbt.io/services.html
--
Dr. Marco Hugentobler
Sourcepole - Linux & Open Source Solutions
Weberstrasse 5, CH-8004 Zürich, Switzerland
[email protected] http://www.sourcepole.ch
Technical Advisor QGIS Project Steering Committee
_______________________________________________
Qgis-developer mailing list
[email protected]
List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
