On 23 February 2017 at 17:34, Nyall Dawson <[email protected]> wrote: > On 23 February 2017 at 17:06, Andrea Peri <[email protected]> wrote: >> Hi, >> we at Tuscany Region in 2013 fundedthe adding of the support of scale >> legend in the wms provider. >> That (if I remenber was added to the 2.2 or 2.4 version of qgis). >> >> These are the commit for that adding: >> >> https://github.com/qgis/QGIS/commit/8fb20f038d9d6c67bafc932ccea1d688ef2d5363 >> >> https://github.com/qgis/QGIS/commit/f6a6a0c017db6306691dca9c9008ef0100574d98 >> >> https://github.com/qgis/QGIS/commit/32da13b20c6a408a975d0e93415a73d20a3c4b59 >> >> https://github.com/qgis/QGIS/commit/48002dbf18392c1d227983b97e8dc65d7eb1f6b6 >> >> https://github.com/qgis/QGIS/commit/d7708437632972b293fe7a511008a910e61c001d >> >> From the 2.6 version as I remenber it was removed > > Which parts are missing or broken? I just quickly flicked through > those commits and the code at least all seems to still be there in > 2.18/master. (I didn't test the functionality, and noticed that > unfortunately there's no unit tests covering any of the original > work.)
Andrea, What was the outcome here? Is there missing functionality? I'd like to know either way - it's a very bad situation for the project's reputation if funded features are broken like this*. Nyall (* insert the usual disclaimer about "no one should ever sponsor a feature without an explicit requirement for unit tests in the contract") _______________________________________________ Qgis-developer mailing list [email protected] List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
