> > Hum, there might be an intermediate option: revert the change in GDAL 2.2 > branch, and keep it in 2.3dev which will probably be released in one year, > at a time where QGIS 3 should have been released to.
I've taken another road finally. Build the internal copy of shapelib of QGIS with some modifications : * prefix all the SHP* and DBF* symbols of it with qgis_ to avoid symbol name clashes * and use GDAL VSI Large file I/O instead of standard lib FILE API so that UTF-8 names are properly handled on Windows. >From my (light) tests, seems to work (on Linux). ==> https://github.com/qgis/QGIS/pull/4413 Even > > > Matthias > > > > On 4/24/17 7:20 PM, Even Rouault wrote: > > > Hi, > > > > > > > - Shape: do not export Shapelib symbols for builds > > > > > > > > --with-hide-internal-symbols (#6860) > > > > > > It turns out that the above change breaks QGIS 2.18 build, in > > > particular the DXF2SHP converter native plugin, since it does a nasty > > > trick: the QGIS build tree has the shapelib 2.10 includes files, but > > > relies on linking against shapelib symbols exported by libgdal. The > > > plugin apparently no longer exists in QGIS master, which builds fine > > > against GDAL 2.2beta2. > > > > > > > > > > > > So I'm not sure what to do: > > > > > > 1) revert #6860 and export again shapelib symbols from GDAL. But this > > > apparently breaks some other workflows > > > > > > 2) let distributions apply a patch to do this revert, while they use > > > QGIS 2.18 or other code that depend on GDAL exporting shapelib symbols > > > > > > 3) Change DXF2SHP plugin to use OGR API instead of shapelib, but I'm > > > not feeling like I would do that myself. > > > > > > > > > > > > My opinion would be to favor 2) > > > > > > > > > > > > Opinions ? > > > > > > > > > > > > Even > > > > > > > > > > > > > > > Spatialys - Geospatial professional services > > > > > > http://www.spatialys.com > > > > > > > > > > > > _______________________________________________ > > > Qgis-developer mailing list > > > [email protected] > > > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > > > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer -- Spatialys - Geospatial professional services http://www.spatialys.com
_______________________________________________ Qgis-developer mailing list [email protected] List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
