why not add the feature to a more detailed notification of what is wrong during commitChanges? Like point out a more detailed report of the failing feature/attribute/geometry? it would just a new signal and EditBuffer cache.
just my 2c Luigi Pirelli ************************************************************************************************** * Boundless QGIS Support/Development: lpirelli AT boundlessgeo DOT com * LinkedIn: https://www.linkedin.com/in/luigipirelli * Stackexchange: http://gis.stackexchange.com/users/19667/luigi-pirelli * GitHub: https://github.com/luipir * Mastering QGIS 2nd Edition: * https://www.packtpub.com/big-data-and-business-intelligence/mastering-qgis-second-edition ************************************************************************************************** On 12 July 2017 at 11:15, Sandro Mani <manisan...@gmail.com> wrote: > > > On 12.07.2017 01:06, Nyall Dawson wrote: >>> >>> Thanks for the insight, I'll look at that approach. >>> >>> Sandro >> >> I might have missed this in the earlier conversation, but why not >> explore the option suggest of using the layer's edit buffer? I believe >> this should automatically handle all the reassignment without any >> changes needed (except flipping the direct dataProvider use to the >> editBuffer). >> >> Possibly it's nicer for users anyway if the fixes made by the plugin >> are buffered and undo-able. > > The problem is that if one of the changes to be committed is refused by the > provider, you're stuck not being able to commit the entire set of changes. > And, since we are dealing with invalid geometries, it is not that unlikely > that this occurs. Committing directly to the provider ensures that we know > immediately whether a change is valid or not. > > Sandro > > _______________________________________________ > QGIS-Developer mailing list > QGIS-Developer@lists.osgeo.org > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer _______________________________________________ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
