On 03.09.2017 23:50, Even Rouault wrote:
> Ok, so if we only do this for non-select queries, we should be safe?
Yes. I suspect the case where a full SELECT statement is used are
rare, and people able to do that can tweak the request. It would be
unreliable to try modifying it.
>
> > > Something like this [1] seems to fix the issue, don't know if
it's the
> > >
> > > best way forward though?
> >
> > I've left a few comments in the commit
>
> Many thanks. I've pushed a revised version at [1].
I've added a couple suggestions for more robustness, but looks good to me.
Thanks, filed PR: https://github.com/qgis/QGIS/pull/5122
Sandro
_______________________________________________
QGIS-Developer mailing list
[email protected]
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
