On Tue, 28 Aug 2018 at 21:42, andreaerdna <[email protected]> wrote: > > andreaerdna wrote > > - the virtual layers show no feature when no filter string is set in the > > Query builder, instead of showing all the features > > Better looking at the code, it seems to me that the bug is in > QgsVirtualLayerFeatureIterator::QgsVirtualLayerFeatureIterator where > "subset" is tested for Null instead that for Empty > > QString subset = mSource->mSubset; > if ( !subset.isNull() ) > { > wheres << subset; > } > > This leads to the insertion of an empty string in the "wheres" list, thus to > the incorrect preparation of an SQL query with the WHERE clause without > condition or the unneeded AND operator.
Great catch, fix merged. Keep these coming -- they are very valuable fixes! Nyall _______________________________________________ QGIS-Developer mailing list [email protected] List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
