I was able to run prepare-commit from WSL by commenting out these lines (74-76) in astyle.sh :
# if type -p wslpath >/dev/null; then # ASTYLEOPTS="$(wslpath -a -w "$ASTYLEOPTS")" # fi It seems they were trying to convert path of the astyle option files from WSL to Windows (/mnt/c/... to c:\). Not sure if this is specific to my setup ? On Wed, 8 May 2019 at 19:53, Olivier Dalang <[email protected]> wrote: > I saw the reference to package-nightly.cmd, but it's not that easy to > follow, at least it wasn't for me. I was thinking of a note like [1] to > help out other new commers. If it makes sense, I can open a PR. > > Also, I'm now stuck with the prepare-commit.sh step under Windows. > I tried with WSL, where the script runs, but failed because of a few > dependencies (astyle itself, autopep8 and a few others, all of which were > easy to apt-get install), but it still fails after that with : > Cannot open default option file /mnt/c/Users/Olivier/Documents/QGIS/C: > Artistic Style has terminated > > I also tired to build with WITH_ASTYLE=ON as suggested on [2], but that > didn't seem to have any effect. I did it like this : > $ cmake -G Ninja -D CMAKE_BUILD_TYPE=RELWITHDEBINFO -D WITH_ASTYLE=ON .. > $ ninja > > Is this the correct way to do it ? > > Thanks !! > > Olivier > > [1] : > https://github.com/qgis/QGIS/compare/master...olivierdalang:ninja_instructions_for_win?expand=1 > [2] : > https://lists.osgeo.org/pipermail/qgis-developer/2017-July/049324.html > > > > On Wed, 8 May 2019 at 10:24, Jürgen E. Fischer <[email protected]> wrote: > >> Hi Olivier, >> >> On Wed, 08. May 2019 at 10:05:27 +0200, Olivier Dalang wrote: >> > Thanks, that was it ! >> >> > I wasn't giving the CMAKE_BUILD_TYPE argument to CMAKE. I'll make a PR >> > shortly to add this info to INSTALL. >> >> doc/msvc.t2t - INSTALL is an output file. >> >> A note to refer to package-nightly.cmd is already there. >> >> >> Jürgen >> >> -- >> Jürgen E. Fischer norBIT GmbH Tel. >> +49-4931-918175-31 >> Dipl.-Inf. (FH) Rheinstraße 13 Fax. >> +49-4931-918175-50 >> Software Engineer D-26506 Norden >> https://www.norbit.de >> >
_______________________________________________ QGIS-Developer mailing list [email protected] List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
