Greeting Nyall, The PR has been rebased and squashed. Changes are at their minimal.
Thanks! Alexis Roy-Lizotte Le mar. 27 août 2019 à 19:53, Nyall Dawson <[email protected]> a écrit : > On Wed, 28 Aug 2019 at 09:46, Alexis R.L. <[email protected]> wrote: > > > > Greetings, > > > > I have a particular PR ( https://github.com/qgis/QGIS/pull/31061 ) that > is in limbo, that PR proposes changes to the QgsVectorLayer and I know that > Matthias wanted me to make this PR in order to obtain feedback from the > community regarding these changes. > > > > This message is simply to see if any other dev/contributor could leave a > simple feedback on the PR. > > > > The changes are minimal and entail caching some information in the > QgsVectorLayer and add a function to access that data. Change are > relatively minimal and I don't think this would overcrowd the vectorlayer > API all that much. If anyone shares the same opinion or otherwise I would > appreciate to know. > > > > Thanks and have a nice day! > > Hey Alex! > > Can you strip out the unrelated changes from that PR? There's changes > in there to the aggregate method which don't seem related, and the > long commit history obscures the rationale behind the changes. > > Nyall >
_______________________________________________ QGIS-Developer mailing list [email protected] List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
