Hi Belgacem, It would be very good to have tests indeed ! If you have them ready, it should be straightforward to enable these on the qt 5.14 build.
Best regards Matthias On Thu, Aug 27, 2020 at 3:13 PM BELGACEM NEDJIMA <[email protected]> wrote: > Hi Matthias, > Yes, I wanted to run the CI tests on a version >= Qt5.10 because if I > disable shadow rendering for <=Qt5.9, it will bypass all the tests and may > add some bugs into the codebase. > > > On Thu, Aug 27, 2020, 1:45 PM Matthias Kuhn <[email protected]> wrote: > >> Hi Peter, >> >> I don't see a problem to conditionally disable shadows for Qt <= 5.10, we >> also have other conditions depending on the Qt version in other parts of >> the codebase. >> Is there a hidden question how to go about testing this in CI? If yes, >> I'd say the best approach would indeed be to enable tests for Qt 5.14. >> >> Best regards >> Matthias >> >> On Thu, Aug 27, 2020 at 1:58 PM Peter Petrik < >> [email protected]> wrote: >> >>> Hi, >>> >>> CI on travis runs with qt 5.9 and for >>> https://github.com/qgis/QGIS/pull/38448 we need to have qt 5.10+. In >>> 5.9 the 3d shadow rendering does not work correctly and since Windows, Mac >>> and latest Linux distributions run on newer qt's I do not see a reason to >>> spend considerable time to fix the 3d shadows for qt 5.9. I was thinking to >>> disable this feature for builds with qt 5.9.I see the qt5.14 build in the >>> repository, but that one is without tests. >>> >>> I am wondering how to best approach this? >>> >>> Thanks, >>> Peter >>> _______________________________________________ >>> QGIS-Developer mailing list >>> [email protected] >>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer >>> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer >> >> _______________________________________________ >> QGIS-Developer mailing list >> [email protected] >> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer >> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer > >
_______________________________________________ QGIS-Developer mailing list [email protected] List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
