Thank you for the response Matthias.

I opened a PR - https://github.com/qgis/QGIS/pull/63613 , and it seems to
have gone well, except 2 of the tests failed.
I think one of the failures was due to the global AWS outage on Monday that
caused some issues with docker hub, but the second one seems to be due to
the PR suggesting changes to a core file ( src/core/project/qgsproject.cpp).

Is there a way I can flag it as ok or should I just wait for a maintainer
to get the time to check it?
I am mostly bothered by the fact that the PR is marked with X as failing
some tests and I don't think I can actually do anything differently right
now.

On Mon, 20 Oct 2025 at 11:19, Matthias Kuhn <[email protected]> wrote:

> Hi,
>
> No need for a QEP for this, just open a PR.
>
> Cheers
> Matthias
>
> On Sun, Oct 19, 2025 at 8:28 AM Dror Bogin via QGIS-Developer <
> [email protected]> wrote:
>
>> Hi all,
>>
>> I was asked last week about accessing project/user bookmarks from the
>> expression engine and found it weird that it was missing.
>> It sounded like a good idea for a plugin, but I found a way to make
>> bookmarks accessible in a relatively easy way by adding the variable inside
>> `QgsProject::createExpressionContextScope` (and adding the help string in
>> `QgsExpression::buildVariableHelp`.
>>
>> Do I need to create a QEP for small changes like that or can I simply
>> create a PR?
>>
>> --
>> Dror Bogin
>> _______________________________________________
>> QGIS-Developer mailing list
>> [email protected]
>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>>
>
_______________________________________________
QGIS-Developer mailing list
[email protected]
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Reply via email to