Alin Dreghiciu wrote: > So, it is all right to have in UnitOfWork: > > <T> T find( String identity, Class<T> compositeType ) > > but not > > <T> Iterable<T> entitiesFrom( Iterabale<EntityId> identifiers ) where > EntityId is just a pair of identity/compositeType
Correct. You are missing the point that the entitiesFrom, and it's discussed use, is only there for the *internal* purpose of getting Query results matched to Entities. Why should the client have to do that? > and change query from extending Iterable<T> to extending Iterable<EntityId> > > and doing so decouple Query from UnitOfWork? Why is it so important to decouple this? And again, the way I see it the main Query implementation that is provided by the EntityFinder *should* return Iterable<EntityId> which the Query from an QoW translates into entities, possibly also filtering out removed Entities at the same time. > PS. Isn't QualifiedIdentity a better name then EntityId? Yes, agree, feel free to rename. /Rickard _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
