On Fri, Aug 1, 2008 at 5:24 AM, Richard Wallace <[EMAIL PROTECTED]> wrote: > Cool. I just committed some things. I made the commit message pretty > detailed so you can easily see what's going on. I'll update the example > project later to make use of that stuff. Excellent.
> I've also got a PackageProvider that will scan and for Composites that also > implement the Action interface or end in Action that I can commit, > but I have to figure out how to get it working properly in a typical webapp > deployment scenario. Is this committed? Coz I can't find the class in qi4j-struts2-plugin. > Right now I have it working where the PackageProvider expects an > ActionConfiguration object to be injected and the ActionConfiguration is > created during the creation of the layers and modules of the qi4j application > so it > can also add what it finds as composites. I'm not sure what this paragraph means as I'm a total struts 2 newbie (This is my first time using struts 2). Now, my feedback on the existing code: o Qi4jContainerProvider I would think it's better to use @Structure to inject ObjectBuilderFactory, CompositeBuilderFactory and UnitOfWorkFactory instead of @Inject. o UnitOfWorkInterceptor I need to investigate when struts 2 rendered the page. Is this done after action invocation? If I understand PreListener javadoc correctly, that is Result is executed outside action execution scope. We would only be able to pause/complete/discard after result is executed. Since we're working on the same code base. We need to divide tasks. I think I would try to complete Qi4jPropertyAccessor and start creating test cases. Regards, Edward Yakop _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
