On Tue, Nov 25, 2008 at 00:08, tao wen <[EMAIL PROTECTED]> wrote: > I am a newbie to qi4j, and quite excited about the whole vision of this > project, so I want to join in some way.
Welcome!. > And I did, by making some damages. I just committed a change to > implementation of > PropertiesMixin to break it down into smaller pieces and split up more > AppliesToFilter. > I don't know the change makes sense or not, if not please revert it back. There is one little bug in OrAppliesToFilter where it behaves like an "And" instead of "Or". > During the process> I've found two questions: > 1. PropertiesMixin only apply to setters and getters, but it also > implemented to response to "Iterator". I am not quite familiar with how > AppliesToFilter works. But I think Iterator is not considered as either > getter or setter according to current implementation. So, I added > @AppliesTo(Iterables.class) to make the mixin handle "Iterator" invoation. Hmm. not so sure. Perhaps a test case is required to ensure that this is the case? > 2. PropertiesMixin was not handling "Is*", "Has*". I don't know if it is > intended to be so, or I deleted mistakenly or I can go ahead and implement > them? Hmm, I think Properties Mixin should be compliant to javabean spec. If Has* is part of the spec. I think that should be implemented. Regards, Edward Yakop _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
