On Fri, Jul 3, 2009 at 1:15 PM, Rickard Öberg<[email protected]> wrote:
> I would suggest refactoring so that: > * QueryBuilderFactory comes from Modules just like the other services > * QueryBuilder.newQuery() is changed to QueryBuilder.newQuery(UnitOfWork), > which would then mirror the already existing QueryBuilder.newQuery(Iterable) I agree with this. > Any issues with this? Possible improvements? Allowing 'null' or having am method without argument, in which case the queryBuilder takes "currentUnitOfWork" would help reduction of UnitOfWorkFactory injections... Not sure if the benefit outweighs the 'extra weight'.... Cheers -- Niclas Hedhman, Software Developer http://www.qi4j.org - New Energy for Java I live here; http://tinyurl.com/2qq9er I work here; http://tinyurl.com/2ymelc I relax here; http://tinyurl.com/2cgsug _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
