On Mon, Feb 15, 2010 at 6:18 AM, Stanislav Muhametsin
<[email protected]> wrote:
> As my application relies heavily on using containsAll query, I've decided to
> implement it myself. And of course it is always fun and interesting to learn
> and use something quite new to oneself.

Cool. Do you have the credentials for commit (we are quite lazy and
don't want too much patches...)? If not, check the
http://www.qi4j.org/qi4j/codebase.html on how to submit me the ssh key
needed.

> If you find any flaws in my implementation, feel free to comment and fix
> them - I tried to produce as reliable code as possible.

I'll look into it, but this is an area where no one has much expertise...

> I've updated the JIRA issue with latest code changes and
> tests (qi4j_core_proper.zip (newer one), qi4j_extensions_proper.zip (newer
> one), tests.zip, git-diff.zip). Would be nice if the changes would be
> integrated to working branch soon.

As I mentioned, we prefer to hand you the commit rights instead.
Generate (or use existing) an SSH key and send to me.

> One thing still left me puzzling a little: I couldn't find code, which
> actually produces the string which can be found in values.dat.

Potential place is the RDF Library...

> Also there was API change to QueryExpressions:
>
> public static <T> ContainsAllPredicate<T>
> containsAll(Property<Collection<T>> proeprty, Collection<T> value)
>
> to:
>
> public static <T, C extends Collection<T>> ContainsAllPredicate<T, C>
> containsAll( Property<C> property, C value )

Looks minor enough to me, possibly even runtime compatible...


Cheers
-- 
Niclas Hedhman, Software Developer
http://www.qi4j.org - New Energy for Java

I  live here; http://tinyurl.com/2qq9er
I  work here; http://tinyurl.com/2ymelc
I relax here; http://tinyurl.com/2cgsug

_______________________________________________
qi4j-dev mailing list
[email protected]
http://lists.ops4j.org/mailman/listinfo/qi4j-dev

Reply via email to