On 2010-09-03 11.50, Paul Merlin wrote:
Quoting Rickard Öberg<[email protected]>:
* I see you make one connection and share it. That is not how
connections are supposed to be used. It would be much better if you
inject a DataSource (implemented by a connection pool) into the
EntityStore, and then retrieve/return connections on each JDBC call.
Otherwise concurrency and error handling becomes a nightmare.

Hi guys,

I just pushed into sandbox a refactoring in entitystore-sql that makes it use a
DataSource. Either backed by a provided Apache DBCP based mixin or using
imported services. Demonstrated in unit tests and working flawlessly \o/

Good stuff! Thanks for working on this!

We're not dead, only busy :)

Same here, so I know the feeling :-)

regards, Rickard

_______________________________________________
qi4j-dev mailing list
[email protected]
http://lists.ops4j.org/mailman/listinfo/qi4j-dev

Reply via email to