On 8/3/11 16:59 , Niclas Hedhman wrote:
Hi,
I have fixed the Qi-327 issue. It is about the
Initializable.initialize() is being called in ValueBuilder.prototype()
(no values set yet) rather than at ValueBuilder.newInstance().

All the testcases passes but can anyone think of where this is not the
correct way??

It really depends on what you do in initializable() I think. In v2.0 the builders are quite a bit different from 1.x. The builder will have the actual instance that will be used when newInstance() is called (i.e. there's just an internal switch that is flipped rather than creating a copy). If the builder part is mostly about setting state, then I suppose it makes sense to do initializable() on newInstance(), so that all state can be assumed to be correct.

/Rickard

_______________________________________________
qi4j-dev mailing list
[email protected]
http://lists.ops4j.org/mailman/listinfo/qi4j-dev

Reply via email to