Paul, On Fri, Jul 13, 2012 at 8:14 PM, Paul Merlin (Commented) (JIRA) <[email protected]> wrote: > [ > http://team.ops4j.org/browse/QI-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585#comment-17585 > ]
> I'm getting close. The new Activation system is fully working and unit tested. Really good to see your effort, and happy that you finally got your feet wet in the internals. > I did not remove the Activatable interface yet because that imply a lot of > tedious changes in libraries, extensions, tools and samples. Yes, this will actually present some major challenge. foreach( Library p ) - Write unit test to capture Activatable functionality. - Remove Activatable. - Unit test should fail. - Introduce the activator replacement - Unit test should succeed. This will take a lot of time. But the nice upside a strengthening of the unittests in libraries, which at the moment is a bit weak. > This is my first big change to the core and it allowed me to dive deeper in > Qi4j core. > I must say that it wasn't difficult because it's well thought and written, > but I already knew that. > Changes have a very little impact on api but more on runtime. Right. What is more important and many projects completely miss, is that in Qi4j there is no doubt whether a class is API or Runtime. And I have been struggling a lot to get as much as possible into Runtime, to minimize the exposure of internal workings. There are some oddities as a result, where one has to go via the Qi4j or Qi4jSPI interfaces, but I think it is worth it. > Before moving forward I would like a code review to confirm I took the right > path and point areas where I could have done something wrong. > > Next steps would be: > - porting all libraries, extensions, tools and samples > - removing the Activatable interface > - impact documentation Right. Not small effort, and it was wise to keep Activatable for now. > Niclas, could you handle the code review please? I will give it a go during this weekend. Cheers -- Niclas Hedhman, Software Developer http://www.qi4j.org - New Energy for Java I live here; http://tinyurl.com/3xugrbk I work here; http://tinyurl.com/6a2pl4j I relax here; http://tinyurl.com/2cgsug _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
