---------- Forwarded Message ---------- Subject: Re: [Qjson-devel] cmake changes Date: Wednesday, August 24, 2011, 08:17:12 PM From: Michael Jansen <[email protected]> To: [email protected]
On Wednesday, August 24, 2011 01:56:11 PM Raphael Kubo da Costa wrote: > Michael Jansen <[email protected]> writes: > > Please consider to not use the lower-case variant. Instead use > > QJson-config.cmake or anything else with at least one UpperCase Letter to > > enforce some consistency here and make it possible to add/use a find > > module in future (see kde-buildsystem "Re: Buildsystem TODO list" alex > > neundorf 24.08). > The only message in the thread on this date is unrelated to this. I > guess you are referring to > http://lists.kde.org/?l=kde-buildsystem&m=131412107710177&w=2 ? > > Even if the lowercase naming persists, how would it prevent a > FindQJSON.cmake in extra-cmake-modules from finding lowercase > qjson-config.cmake? Because for module mode cmake does not do the lowercase magic. If you keep the all lowercase file and later add a Findqjson.cmake it will only work for people doing find_package(qjson) [the exact same upper/lowercase notation]. People doing find_package(Qjson) will skip over the module file (FindQjson.cmake not found) and get directly the config file. So they don't get the intended result / workflow / steps but no error. The same goes for FindQJSON.cmake. Everything but find_package(QJSON) will skip over module mode and directly use config mode file. Only if the config file has at least one uppercase letter you can later overlay it reliably with a module mode file so you get an error if you mispell? (different lower/uppercase combination) the package name. Mike ----------------------------------------- -- Michael Jansen http://michael-jansen.biz ------------------------------------------------------------------------------ EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev _______________________________________________ QJson-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qjson-devel
