Hi Krzysztof, I ask Frank and he says it's ok from his point of view (however he is far from a development environment to check it in depth). I would like to apply the patch, but it fails as it can't synchronize with my working copy. I think I made too many chnages the last days.
Thus I would like to ask you to create the patch once again after "svn up". Do a "svn diff > patch.txt" from the source root. Please attach the file. Do not paste it into the mail. That makes the whole process easier and foolproof for me :) > > Anyway: > - I have removed now unused abstract ILink class (serial and USB are > completely separate, drivers talk to either one but not to both). Well, I prefer to define basic interfaces by a pure virtual interface class. On the otherhand side the devices are tied to a single interface type, thus the ILink class is indeed not very usefull. As I do not expect this to change in future I is ok too me to drop it. > > Another idea: perhaps we should change the speed to 115200 bps on > startup (init, first command etc) and don't go back to 9600 until > maybe quit or some timeout? At least my receiver works perfectly well > with that. I just recall that one device was trashed by such an action :) But I can't recall the details. Not sure if that is safe. > > A question: the code uses 'endl' everywhere, is there a specific > reason for it? Isn't it slower and less readable than a usual "\n"? IMHO as C++ programmer it's perfectly readable. And I never made a real analysis if printf, streaming or any other output method is superior than the other. These are debug messages and they usually go to /dev/null. I don't think it's worth a second to think about it ;) Oliver ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ QLandkarte-users mailing list QLandkarte-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/qlandkarte-users
