On Wed, 2 Nov 2011, Oliver Eichler wrote:
Patch (against trunk) is attached. The functionality can be switched on
and off the config dialog. Currently it's also possible to directly
enter the epsilon value there.
Woah! What a patch! That stuff is cool. I challenged it with various
maps today. It's really impressive. Especially on the outer zoom scales
the major street polylines where a performance hit. Now they render
quite as fast as the polylines on the closer zoom levels.
Additionally it flattens the ugly staircase polylines that seem to be en
vogue on outer zoom scales these days. The only caveat I recognized
where some edgy polylines of large curves like highway ramps.
That stuff has to make it into svn. I would just like to ask you for a
few changes:
* Skip making it an option. The benefits are good enough to have it
permanently on. And I doubt that 99% of the users know what it does, how
it works and why to use this option anyway.
ok, we just have to find a good value for ε then. I'll keep it in
QSettings for the time being and just remove it from the UI, ok?
* But switch it off for closer zoom levels. Map contributor will get a
heart attack if they do not see their polyline as defined. On closer
views the speed up is not noticeable anyway.
ok, although in principle this should not be necessary, as ε is
expressed in pixel units anyway. Where do the closer zoom levels begin?
* Get rid of that class in a method. :) That is ugly. And it only
defines a single method anyway.
Well, it defines a local function, something that isn't allowed in C++.
I don't think it's *that* ugly, but I'll remove it ;-)
* There is a 2nd draw method for lines. That has to do the optimization,
too. It draws the foreground of a two color road.
ok
Good work!
Thanks!
Michael
--
#exclude <windows.h>
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Qlandkartegt-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qlandkartegt-users
