I wanted to forward this to the Q-S list since I am wondering if the proposed changes in sophie's error codes will affect Q-S. Does anyone know if any mods need to be made to Q-S to handle the change in error codes?
Thanks, --- Ed -----Original Message----- From: [EMAIL PROTECTED] Sent: Monday, November 24, 2003 4:01 AM Subject: Re: [vtools] Sophie 3.04rc1 released Hi list! I think Sebastian's scandir patch looks good and should be applied. However, consequences should be clear: Without configure option --enable-only-fatal-err each internal error would be reported as -1. It depends on calling program what happens then. Amavis, e.g. has an internal switch called $requeue_on_scanner_errors (default = "yes") which would make amavis requeue the mail. But that would make no sense for a corrupted or encrypted mail, it will not be different next time. There was a discussion on the list about it some time ago. So in this environment --enable-only-fatal-err should be strongly recommended, otherwise such mails would be blocked (and a mail scanner should not block mails he cannot decrypt). virus non fatal error fatal error ---------------------------------------------------------------- sophie3.03 1 0 0 sophie-3.04rc1 1 0 0 sophie-3.04rc1 1 -1 -1 with scandir-patch sophie-3.04rc1 1 0 -1 with scandir-patch --enable-only-fatal-err Those who would prefer to completely keep old behavior of sophie must make the calling program treat -1 return code always the same as 0. I think it should be mentioned within docs because the patch would change sophie's behaviour. Dirk Sebastian Hagedorn wrote: > Hi Vanja, > > -- Vanja Hrustic <[EMAIL PROTECTED]> is rumored to have mumbled on > Samstag, 22. November 2003 1:26 Uhr +0100 regarding [vtools] Sophie > 3.04rc1 released: > >> Sophie 3.04rc1 has been released. >> >> Changes: >> >> - Applied Sebastian Hagedorn's patch, which causes Sophie to return >> 0 for non-fatal errors. Thanks to Sebastian for this patch. >> >> NOTE: This patch adds --enable-only-fatal-err configuration >> option, and has to be enabled manually > > > thanks for accepting my patch. > > However, I note that you did not change the behavior of sophie_scandir. > The issue is that -1 error conditions are ignored: > > /* If virus was found - return 1 */ > if ((sophie_scanfile(path)) > 0) { > closedir(dirpt); > return(1); > } > > I have attached a new patch that tries to deal with this. Please let me > know what you think ... > > Greetings, Sebastian > -- > Sebastian Hagedorn M.A. - RZKR-R1 (Flachbau), Zi. 18, Robert-Koch-Str. 10 > Zentrum für angewandte Informatik - Universitätsweiter Service RRZK > Universität zu Köln / Cologne University - Tel. +49-221-478-55 > 87 > > > ------------------------------------------------------------------------ > > _______________________________________________ > vtools mailing list > [EMAIL PROTECTED] > http://www.vanja.com/list/listinfo.cgi/vtools _______________________________________________ vtools mailing list [EMAIL PROTECTED] http://www.vanja.com/list/listinfo.cgi/vtools ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ Qmail-scanner-general mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/qmail-scanner-general