> I've uploaded qmail-lint-0.50 to www.qmail.org.  It checks for common
> problems in your qmail control files.  If you try it, and it prints
> something you don't understand, or you think is not a problem, send me 
> email.  Or if it misses a known problem, I'd also to hear about that
> as well.

Comments in control/locals are treated somewhat strangely. All lines are pushed
onto @locals, but only those which aren't comments are added to %locals. Then
comments matching /^#\s/ are treated differently to those which don't. I get:

Warning: a host # Web server names in locals does not appear in rcpthosts.
Warning: a host  in locals does not appear in rcpthosts.

... where the first warning is for "# Web server names" and the second is for
"#physicsweb.org"

I don't understand the distinction between different types of comment, but this
patch ignores comments completely anyway:
*** qmail-lint-0.50     Tue Jan 26 13:45:48 1999
--- qmail-lint  Tue Jan 26 16:05:30 1999
***************
*** 24,29 ****
    while(<F>) {
      chomp;
-     push(@locals,$_);
      next if m"^#";
        $locals{$_} = "";
    }
--- 24,29 ----
    while(<F>) {
      chomp;
      next if m"^#";
+     push(@locals,$_);
        $locals{$_} = "";
    }
***************
*** 36,41 ****
    while(<F>) {
      chomp;
-     push(@virtualdomains,$_);
      next if m"^#";
        if (split(/:/) < 2) {
        print "Warning: Line $. in control/virtualdomains has no colon:\n";
--- 36,41 ----
    while(<F>) {
      chomp;
      next if m"^#";
+     push(@virtualdomains,$_);
        if (split(/:/) < 2) {
        print "Warning: Line $. in control/virtualdomains has no colon:\n";





-- 
        Peter Haworth   [EMAIL PROTECTED]
"The net serves four of the five physical senses. You can get sight, and
sound, and to a limited extent tactile feedback. No one would deny that
some portions of the net smell, but I see no signs that taste will ever
come to the net."               -- bill davidsen

Reply via email to