On Wed, 11 Oct 2000, Erik Sjoelund wrote:

> It looks strange in qmail-local.c as of qmail 1.03
> 
> line 648 in qmail-local.c  is written
>      while ((k > i) && (cmds.s[k - 1] == ' ') || (cmds.s[k - 1] ==
> '\t'))
>        cmds.s[--k] = 0;
> 
> 
> Because && has higher precedence than ||,
> I suppose that was meant to be written was
> 
>     while ((k > i) && ((cmds.s[k - 1] == ' ') || (cmds.s[k - 1] ==
> '\t')))
>        cmds.s[--k] = 0;
> 
> this could lead to strange behaviour for a  .qmail starting
> with just tabs followed by a newline. As  strange behaviour I
> mean referencing the array with index -1
> 
> Sorry if I'm mistaken, please correct me if I'm wrong

Given that the dot-qmail man pages says:

    ...

    .qmail may contain extra spaces and tabs at the end  of  a
    line.  Blank lines are allowed, but not for the first line
    of .qmail.

    ...

it's not really a bug.

-- 
Regards
Peter
----------
Peter Samuel                            [EMAIL PROTECTED]
http://www.e-smith.org (development)    http://www.e-smith.com (corporate)
Phone: +1 613 368 4398                  Fax: +1 613 564 7739
e-smith, inc. 1500-150 Metcalfe St, Ottawa, ON K2P 1P1 Canada

"If you kill all your unhappy customers, you'll only have happy ones left"

Reply via email to