I'm not sure if this problem exists in 0.35 as well or not but the patch is 
pretty simple.

I have a question regarding the development in general... are the features 
*tested* before they are shipped out or how exactly do simple simple bugs 
like this creep in?  there is no possible way that a list could be created 
as the code originally stood.

I am not ripping on the programmers... Lord knows how hard it is to create 
something nice and complex like this but I know from my own development 
experiences that if you're working on some aspect of the program (in this 
case the mailing list) you at least *test* the changed functions before 
releasing it out to the world, development or no.  A simple "create list / 
drop list" would have shown this to not work at all.

Regards,
Andrew



--- old/mailinglist.c   Sun Sep 10 16:31:32 2000
+++ new/mailinglist.c       Sun Sep 10 16:32:05 2000
@@ -307,7 +307,7 @@
        memset(loop_ch, 0, MAX_BUFF);
 
        GetValue(TmpCGI, list_owner, "5=", MAX_BUFF); // Get the listowner
-       strcat(owneremail, "-5 ");
+       strcpy(owneremail, "-5 ");
        strcat(owneremail, list_owner);
 /*     strcat(options, " "); */
        for(loop = 0; loop < NUM_EZMLM_CHOICES; loop++)
@@ -356,6 +356,8 @@
                arguments[i+2]=TmpBuf3;
                arguments[i+3]=ActionUser;
                arguments[i+4]=Domain;
+                arguments[i+5]=NULL;
+
                execv(TmpBuf1, arguments);
 #else
                execl(TmpBuf1, "ezmlm-make", TmpBuf2, TmpBuf3, ActionUser, 
Domain , NULL);



Reply via email to