Excellent!!! I've applied the patch and uploaded a oct25 qmailadmin-0.35
development version. This fixes almost all the problems.

After reading the line "vauth_getall bombs when there are no users to
retrieve"
I checked through the vpopmail auth module code for the vauth_getall
function,
and sure enough, you can cause it to crash with pointer errors if it's
not called with the correct inputs. So I fixed each of the auth modules
to have more error checking. I tested the cdb and mysql modules and it 
fixed the errors.

So with qmailadmin-0.39 Oct25 and vpopmail-4.9.5 Oct25, these bugs
are fixed. And Hampton's code works great!

Ken Jones

Hampton Maxwell wrote:
> 
> Patch for user.c (.39 of Oct. 19)
> This patch fixes two things:
> 1. Bug in the Index feature of Pop Accounts.  Previously if you clicked on 'I' and 
>there were users under 'I' it would take you to the last page of pop accounts.  It 
>now sends you to the page with 'H' or 'G' or whatever.  Somebody on the list 
>mentioned this previously causing an Internal Server error.  I can't get that to 
>appear on my machine but this patch very well might fix it anyway.
> I am guessing that this error and the Internal Server Error when clicking on Next 
>Page with no users is that vauth_getall bombs when there are no users to retrieve.  I 
>don't know why certain configs get this and mine doesn't (are you guys using MySQL, 
>somebody want to comment on this).  Since I can't get it to appear on mine it's been 
>pretty difficult to troubleshoot.
> 
> 2. When you click Next Page with no users left, now displays the Previous Page 
>button, Index, Go To User, etc. but no Next Page button.  I was getting annoyed with 
>it saying return to the previous page, but having no button to click on.
> 
> If anybody can give me some pointers on what might be happening which those server 
>errors I'll try and nail em.  Also, don't know if they were fixed in the Oct. 19 .39 
>release.
> 
> Hampton
> --
> SysAdmin / Code Hacker - 101freeway.com
> [EMAIL PROTECTED]
> Software projects: http://www.xsta.cc/
> 
>   ------------------------------------------------------------------------
> 
>    user.c.patchName: user.c.patch
>                Type: Plain Text (text/plain)

Reply via email to