On Wednesday, October 23, 2002, at 02:34 PM, Matt Simerson wrote:
At long last.Thanks for the updated patch. As I've mentioned (off-list) before, there are a few issues with this path that need to be addressed:
All the known problems with qmailadmin and MySQL replication are now fixed. In cases where MySQL slave(s) fail replication there could be a race condition but fixing that requires some code additions to vpopmail. My patch is based on Bill's patch that fixes the MySQL replication issues. To that base I applied Justin Hopper's quota patches and adjusted the quota patches to work the same way as the rest of modusergo (as with Bill's updates).
The patch is at http://matt.simerson.net/computing/mail/toaster/qmailadmin-106- quotafix.txt.
The patch applies cleanly to qmailadmin-1.06. In addition to the quota patches, I also did a bunch of pretty work to the HTML. The most substantial is on the modify user page. See the jpg here:
http://matt.simerson.net/computing/mail/toaster/qmailadmin_quota.jpg
I'd love to know what you think about it. I added some Javascript to that page so that users could only make mail routing choices that make sense. I'd appreciate if people would have a look at it and let me know what they think.
If everyone likes the changes, I respectfully request that the changes be incorporated into the qmailadmin source.
Matt
PS: I'm running this code on a production system with 50,000+ users, using replicated MySQL databases and the aforementioned code.
1. Lack of full Maildir++ support. The only quota format available is in MB. Also, getting current quota usage does dot adhere to the Maildir++ spec, and will need to be updated. (currently uses a du style function, which is accurate, but not as efficient)
2. This patch needs to be conditional. Many of us do not want our customers to have the ability to change quotas. IMO, it should be both a configure option and a .qmailadmin-limits option (which is overridden by the configure option).
I'm happy to make these modifications, and will start on these tomorrow.
Regards,
Bill Shupp
